KarpelesLab / goro / 25825063353

13%

push

github

vm: validate string-offset string keys (TypeError on non-numeric)

PHP 8+ throws "Cannot access offset of type string on string" when a
non-numeric, non-empty string is used to index a string value (e.g.
\$str['wrong']). The VM was emitting "Illegal string offset" warnings
instead. The check mirrors AST behaviour: empty offsets fall through
(treated as 0) and leading-numeric strings like "0foo" continue to
the existing warning path inside ZStringArray. Fixes bug31098.

Also rename isLeadingNumeric → IsLeadingNumeric in core/compiler so
the helper can be referenced from sibling docs; the VM keeps an
inlined copy to avoid a compiler→vm import cycle.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

4 of 36 new or added lines in 4 files covered. (11.11%)

13967 of 115813 relevant lines covered (12.06%)

2451.05 hits per line