KarpelesLab / goro / 25825468160

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: AST-delegate reference assignment (\$b = &\$a)

OpStoreLocal's array COW path (\`v.Nude().Dup()\` for ref ZVals)
breaks the share semantics that a reference assignment needs to
maintain: \`\$b = &\$a; \$b[] = true;\` was leaving \$a unmodified
because the ref ZVal coming out of runRef.Run was Nude+Dup'd into
a detached array. Delegate the whole \`=&\` to the AST runner,
which goes through the FuncContext hashtable; OP_REFRESH_SLOTS
picks up the now-shared inner ZVal afterwards.

Fixes dereference/dereference_003 and the bug-72543 family.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

10 of 10 new or added lines in 2 files covered. (100.0%)

160 existing lines in 2 files now uncovered.

14002 of 115831 relevant lines covered (12.09%)

2457.91 hits per line