KarpelesLab / goro / 25824838995

13%

push

github

vm: validate offset type on array/string read/write (TypeError on object/array key)

PHP 8+ throws "Cannot access offset of type X on array/string" when
the key passed to $arr[k] or $s[k] is an object or array (except on
ArrayAccess containers). The VM previously dispatched these through
the generic OffsetSet path, which produced an "Illegal string offset"
notice instead. Validating up-front in both arrayGet and arraySetLocal
matches the AST's behaviour and fixes bug81159 / closure_array_offset_error.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

8 of 38 new or added lines in 1 file covered. (21.05%)

13963 of 115784 relevant lines covered (12.06%)

2451.66 hits per line