KarpelesLab / goro / 25815850621

13%

push

github

compiler: pre-register top-level functions in lazy table at parse time

Inside compileFunc, when we finish parsing a top-level named
function declaration, RegisterLazyFunc immediately so the rest of
the current compilation pass — most importantly class method bodies
that follow in the source — can resolve forward references at emit
time (e.g. \`FunctionTakesByRef\` queries the lazy table for the
callee's signature).

Previously the lazy registration happened only at the end of
compileInner's top-level scan, so methods compiled inside class
bodies always missed forward-ref top-level functions and emitted
value-passing native calls that silently dropped by-ref bindings.

The main script body's later linear scan over its runnables will
hit the same ZClosure pointer; same-closure RegisterFunction is a
no-op (see the phpctx fix earlier).

Targets bug71622 and similar forward-ref by-ref user-function tests
that the earlier emit-time gate failed to fix without causing
collateral damage.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

4 of 4 new or added lines in 1 file covered. (100.0%)

13955 of 115746 relevant lines covered (12.06%)

2452.45 hits per line