KarpelesLab / goro / 25814545303

13%

push

github

vm: COW array values stored into other arrays

PHP array literals and \`\$container[k] = v\` writes copy array
values by value. The VM was storing the raw ZVal pointer, which
made \`\$a[0] = \$a\` create a self-cycle instead of snapshotting
the empty-\$a state.

Mirror the AST's ZVal()/Dup() behaviour in:
* arraySetLocal (OP_ARRAY_SET_LOCAL / OP_ARRAY_APPEND_LOCAL)
* OP_ARRAY_INIT_APPEND (literals \`[\$a, …]\`)
* OP_ARRAY_INIT_KEYED (literals \`[k => \$a, …]\`)

Skip the Dup when the value is a reference (ref propagation
intentional in \`\$arr[k] = &\$x\`).

Fixes bug38469 ("Unexpected creation of cycle") and related
tests that depend on snapshotting array values on insert.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

9 of 11 new or added lines in 2 files covered. (81.82%)

13964 of 115645 relevant lines covered (12.07%)

2454.85 hits per line