KarpelesLab / goro / 25814441995

13%

push

github

vm: deref ref-bound arrays before COW Dup on plain assign

Plain assignment in PHP dereferences refs on the RHS: \`\$b = \$a\`
when \$a is bound by reference still produces an independent value
copy in \$b (not another alias to the ref). Previously the storeLocal
COW only fired for non-ref values, leaving \`\$original = \$bigarray\`
sharing the ref's underlying ZArray after a prior \`shuffle(\$bigarray)\`
had MakeRef'd \$bigarray's slot.

Now: for array RHS, follow the ref chain via Nude() and Dup the
underlying array. Plain non-ref arrays Dup directly as before.

Fixes basic/array/array_shuffle_basic.phpt and a few related
tests that depend on a second by-ref builtin call not aliasing
through a prior MakeRef'd slot.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

5 of 7 new or added lines in 1 file covered. (71.43%)

13958 of 115637 relevant lines covered (12.07%)

2455.0 hits per line