KarpelesLab / goro / 25814084004

13%

push

github

vm: COW arrays on local assign (matches AST's ZVal.ZVal())

\`\$b = \$a\` was sharing the underlying ZArray between \$a and \$b
because OpStoreLocal stored the popped ZVal pointer as-is. The AST
\`=\` operator calls res.ZVal() which has a special case for
ZtArray: \`a.Dup().ZVal()\` returns a fresh ZArray with cow=true,
so subsequent in-place mutations (sort, array_push, …) hit a
copy.

Mirror that semantics in storeLocal: if the value is a non-ref
array, Dup() before storing. Refs propagate, scalars stay
cached-singleton.

Fixes the basic/array/{sort,arsort,asort,krsort,ksort,natsort,
rsort,array_shuffle}_basic phpt regressions that all rely on
\$temp_array = \$source not aliasing the source array.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

3 of 3 new or added lines in 1 file covered. (100.0%)

13834 of 115633 relevant lines covered (11.96%)

2433.44 hits per line