KarpelesLab / goro / 25813362189

13%

push

github

vm: OpArrayInitKeyed key-type validation (parity with runArray.Run)

The AST array-literal runner rejects object/array keys with TypeError,
deprecates null keys, emits the PHP 8.1 float-precision deprecation
on float keys that lose precision, and casts resource keys to int
with a warning. The VM's OpArrayInitKeyed skipped all of that and
just called OffsetSet — silently dropping the diagnostics tests
expect.

Mirror the AST checks. Fixes the array_keys_basic test and a number
of other sort/shuffle phpt failures that depended on the float-key
deprecation surfacing.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

4 of 25 new or added lines in 1 file covered. (16.0%)

13827 of 115630 relevant lines covered (11.96%)

2433.4 hits per line