lsm / neokai / 25779597104

81%

Build Type

push

github

Committed by web-flow

Commit Message

Add workflow topic subscription trie (#1879)

* feat: add workflow topic subscription trie

Index external-event subscription patterns with exact and segment-local wildcard matching so workflow runtime lookups can avoid linear scans.

* refactor: make topic validator source-agnostic

Remove hardcoded 4-segment format from validateGlobPattern and
validateLiteralTopic. Different event sources use different topic
shapes (GitHub: 5 segments, Slack: 3 segments, Jira: 3 segments).

The general-purpose validator now enforces only universal structural
constraints (non-empty, at least 2 segments, no empty segments,
no .., no **, valid characters). Source-specific depth and format
checks are delegated to each extension.

Updates:
- topic-validator.ts: remove segment count and resource.action checks
- topic-validator.test.ts: update for relaxed validation
- topic-trie.test.ts: use realistic 5-segment GitHub topics
- external-event-store.test.ts: update validation expectations
- design doc: reflect source-specific topic format

* fix: add GitHub literal validation and update test fixtures

Add source-specific validation to validateLiteralTopic for registered
sources while keeping validateGlobPattern source-agnostic for
subscription patterns.

For GitHub literal topics (published events), enforce:
- Exactly 5 segments (source/owner/repo/resource/entityId.action)
- Final segment must contain exactly one dot (entityId.action)
- Neither side of the dot can be empty

This prevents malformed GitHub literals from being stored and never
matched by intended subscriptions. validateGlobPattern remains
source-agnostic to support flexible subscription patterns.

Changes:
- topic-validator.ts: add validateGitHubLiteralTopic helper
- topic-validator.test.ts: add tests for GitHub literal validation
- external-event-store.test.ts: update fixtures to 5-segment format
- design doc: update validation section to say "at least 2 segments"

* fix: add source-specific validation for Git... (continued)

Coverage Stats

8323 of 11590 branches covered (71.81%)

Branch coverage included in aggregate %.

83 of 83 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

64892 of 77306 relevant lines covered (83.94%)

290.26 hits per line