KarpelesLab / goro / 25773911250

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: OP_SYNC_SLOTS + AST delegation for unknown-callable by-ref calls

The previous attempt to handle by-ref function/method calls to
unknown callables (compile-time signature unknowable) AST-delegated
the call AND marked the surrounding body slot-unsafe. Marking the
body slot-unsafe broke 52 unrelated tests that depended on slot-
only semantics.

Add a new OP_SYNC_SLOTS opcode that flushes all non-nil slots to
the FuncContext hashtable. Pair it with OP_REFRESH_SLOTS around an
AST-delegated call: the AST reads fresh values, then any writes
flow back into slots after. The surrounding body stays slot-only;
only the specific call site pays the sync cost.

emit_call.go now uses emitCallViaASTSync for the unknown-callable
case (both direct \`foo(\$x)\` and indirect \`\$f(\$x)\` forms).
This closes the by-ref user-function regressions (bug71622,
bug72038, etc.) without the previous wholesale slot-unsafety cost.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

7 of 33 new or added lines in 3 files covered. (21.21%)

7 existing lines in 1 file now uncovered.

14054 of 115638 relevant lines covered (12.15%)

2039.21 hits per line