KarpelesLab / goro / 25773320920

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: revert the conservative by-ref gate for indirect/unknown calls

The previous attempt to AST-delegate every call to an unknown callee
or every indirect call whose args include a writable lvalue caused
~60 new regressions (any body containing such a call became
slot-unsafe, and the cascading hashtable-backed locals broke other
paths that depended on slot-cached state).

Revert to the narrower gate: only AST-delegate based on known
by-ref signatures (lazy table hit + ref param, by-ref builtins,
named/spread args). The tests that motivated the conservative gate
(bug71622, bug72038, etc.) will need a different solution — likely
extending the call protocol to pass writable refs through the VM
stack rather than pre-evaluating them.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

7 of 7 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

14012 of 115523 relevant lines covered (12.13%)

2041.54 hits per line