KarpelesLab / goro / 25773242658

13%

push

github

phpctx: RegisterFunction(same-closure) is a no-op, not an error

The AST replaces resolved lazy entries with phpv.RunNull{} so the
script body's later linear scan skips them. The VM-compiled script
body holds direct references to ZClosures and can't be patched the
same way; when a top-level function is called BEFORE its declaration
runs, the call triggers lazy resolution → RegisterFunction; later
the bytecode hits OpMakeClosure on the same ZClosure and calls
RegisterFunction again, which would error.

Treat the same-closure re-register as a no-op. Different closure
pointers (true redeclaration) still error.

Fixes the redeclare-class/function failures (by_ref_optimization,
bug43426, bug63741, etc.) that surfaced under GORO_VM=1.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

1 of 10 new or added lines in 1 file covered. (10.0%)

14014 of 115525 relevant lines covered (12.13%)

2041.5 hits per line