KarpelesLab / goro / 25772911907

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: AST-delegate method calls with writable args (by-ref safety)

Instance method calls can't be statically resolved without a
polymorphism analysis — \$obj->method() might dispatch to an
override that declares a by-ref parameter (e.g. an optional &\$x
added in a subclass, as in add_optional_by_ref_arg.phpt). When any
arg is a writable lvalue (variable, array elem, property, etc.)
that could be the ref-bound target, AST-delegate the whole call so
the AST's CallZVal path performs the proper binding.

Non-writable args (literals, expression results) still use the
native OpObjectCall fast path.

IsSlotSafe rejects bodies containing such method calls so the
hashtable mirror is populated when the AST delegation runs.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

14 of 14 new or added lines in 3 files covered. (100.0%)

18 existing lines in 2 files now uncovered.

14006 of 115492 relevant lines covered (12.13%)

2042.08 hits per line