decentraland / asset-bundle-registry / 25758965491

72%

main: 71%

Pull #118

github

fix: serialize concurrent restoreFromHistoricalRegistry via SELECT FOR UPDATE

Two simultaneous texture events for different platforms of the same purged
entity could both read the historical row before either committed. The
slower thread would then upsert the row back into registries using its
stale historical view, overwriting any bundle update the faster thread had
already applied (e.g. windows=COMPLETE stomped back to PENDING).

Lock the historical row with SELECT ... FOR UPDATE so concurrent restores
for the same entity serialize cleanly: the loser sees the row deleted and
returns the live registries row without writing.

619 of 909 branches covered (68.1%)

Branch coverage included in aggregate %.

37 of 47 new or added lines in 4 files covered. (78.72%)

1619 of 2243 relevant lines covered (72.18%)

37.82 hits per line