KarpelesLab / goro / 25756952870

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: native ternary + isset/empty/unset/parens delegation

Five common idioms that previously aborted VM compile for the whole
surrounding function:

* Ternary as an expression (cond ? a : b) and short ternary (cond ?: alt)
  are lowered natively to JMP_IF_FALSE / JMP_IF_FALSE_PEEK + JMP. The
  statement form was already supported via emitStmt; this adds the
  expression form so functions like \`return X ? A : B;\` compile.
* isset() and empty() are AST-delegated as value-producing expressions
  via OpClassConst.
* unset() is AST-delegated as a void operation, followed by
  OP_REFRESH_SLOTS so any unset-of-local nulls the slot cache.
* (expr) wrappers are stripped at the start of emitExpr so the
  surrounding context dispatches on the inner node directly.

IsSlotSafe rejects bodies containing isset/empty/unset so the
hashtable stays authoritative under the AST delegation.

The sentinel "unsupported still falls back" tests are updated to use
spread-arg calls (still unsupported) since the prior triggers are
now compiled.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

70 of 83 new or added lines in 3 files covered. (84.34%)

24 existing lines in 5 files now uncovered.

11592 of 115141 relevant lines covered (10.07%)

1501.79 hits per line