KarpelesLab / goro / 25756700880

13%

push

github

vm: foreach by-ref and non-local targets via AST delegation

Native foreach opcodes only support \$local value/key targets and
value semantics. The by-ref form (foreach(\$arr as &\$v)), the
non-local value target (foreach(\$arr as \$obj->prop)), and the
non-local key target previously aborted bytecode compile for the
surrounding function.

Route those through the AST-delegation pattern (OpTryFinally +
OP_REFRESH_SLOTS) and mark bodies containing such a runnableForeach
slot-unsafe so the hashtable is authoritative while the AST runs
the loop body.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

32 of 34 new or added lines in 2 files covered. (94.12%)

11195 of 115057 relevant lines covered (9.73%)

1351.59 hits per line