agama-project / agama / 25728644292

81%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(web): improve UX of storage mount point inputs (#3445)

## Problem

The usage of the internally called `SelectTypeaheadCreatable` component
(a wrapper around [PatternFly’s typeahead Select with support for
creating new
options](https://www.patternfly.org/components/menus/select/#typeahead-with-create-option))
has proven frustrating for users. When a user types a value and presses
`Tab`, the input is discarded unless they explicitly select the “Use X”
option, which is not intuitive. Also, its dropdown appearance had
mislead some users into thinking it only supports predefined selections
rather than free text input. [~~This is a deliberate design decision in
PatternFly, not a
bug,~~](https://github.com/agama-project/agama/pull/3445#issuecomment-4352350413)
This makes the component fundamentally unsuitable for a field where free
text must always be preserved.

## Solution

To address this usability problem, a lightweight [wrapper around a plain
`<TextInput>` and a native HTML
`<datalist>`](https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/datalist)
has been added as a new `SuggestionsTextField` component. The browser
handles suggestion presentation natively and does not require custom
keyboard navigation, ARIA wiring, or focus management. The input behaves
exactly like a normal text field, and suggestions reflect their purely
optional, assistive nature instead of behaving like options users must
choose from.

## Before vs after

| | Before (`SelectTypeaheadCreatable`) | After (`SuggestionsTextField`)
|
|---|---|---|
| **Props per call site** | 5 required (toggleName, listName, inputName,
clearButtonName, createText) | 2 required (value, suggestions) |
| **Tab behaviour** | Discards typed value unless "Use X" is explicitly
clicked | Always preserves typed value |
| **Free text** | Requires explicit "Use /home" action to commit |
Native, no forced selection |
| **Helper text** | "Select or enter a mount point" | "E.g., /home,
/v... (continued)

Coverage Stats

4014 of 6157 branches covered (65.19%)

Branch coverage included in aggregate %.

42 of 45 new or added lines in 4 files covered. (93.33%)

185 existing lines in 3 files now uncovered.

22409 of 27250 relevant lines covered (82.23%)

96.12 hits per line