ruby-grape / grape / 25718848653

97%

master: 97%

Build Type

Pull #2709

github

Committed by ericproulx

Commit Message

Lift trailing if/else into guard clauses; tighten Lazy::ValueEnumerable

- DSL::InsideRoute#content_type: `if val` if/else -> guard clause.
- DSL::InsideRoute default status: collapse the delete-branch if/else
  into a ternary inline with the surrounding `case/elsif`.
- Middleware::Error#run_rescue_handler: lift the three-arm if/elsif/else
  on `response` into two early-return guards.
- Middleware::Versioner::Header#strict_accept_header_negotiation: lift
  `if media_type` into a guard clause returning the yielded value.
- Path#build_suffix: lift the three-arm if/elsif/else into guards;
  inline the `!a || (b || c)` De Morgan as `!a || b || c`.
- Validations::ParamsScope#build_full_path: lift the three-arm
  if/elsif/else into guards.
- Util::Lazy::ValueEnumerable:
  - `[]`: if/else -> guard clause for the missing-key path.
  - `fetch`: replace dup+shift+recursion with a flat `reduce`.
  - `[]=`: pull the Hash/Array/else case dispatch into a `value_class`
    local so the single `@value_hash[key] = value_class.new(value)`
    assignment is shared.

No behaviour change.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #2709: Lift trailing if/else into guard clauses; tighten Lazy::ValueEnumerable

Coverage Stats

1075 of 1157 branches covered (92.91%)

Branch coverage included in aggregate %.

21 of 22 new or added lines in 6 files covered. (95.45%)

6 existing lines in 3 files now uncovered.

3467 of 3523 relevant lines covered (98.41%)

32143.67 hits per line