ben-manes / caffeine / #5457

100%

push

github

Filter null entries from loadAll replace-existing loader results

CacheLoader.loadAll may return a map containing null keys or values
(the spec contract recommends against it, but defensive consumers
handle it anyway). The keep-existing branches in both CacheProxy and
JCacheLoaderAdapter already filter such entries before put; the
replace-existing branches did not. A loader returning a HashMap with
a null value would hit requireNonNull(value) inside putNoCopyOrAwait
midway through iteration, wrap NPE as CacheLoaderException, and
deliver it via the listener — but only after earlier keys had already
been put, leaving the cache in a partial-commit state.

Hoist loadAllAndReplaceExisting from private to protected so
LoadingCacheProxy can share it, then have both proxies route through
the same filtered path the keep-existing branches use.

4013 of 4022 branches covered (99.78%)

3 of 3 new or added lines in 2 files covered. (100.0%)

8239 of 8239 relevant lines covered (100.0%)

1.0 hits per line