ben-manes / caffeine / #5455

100%

push

github

Restore 100% line and branch coverage in the jcache module

After the spec-compliance sweep introduced new branches and a few
dead-code paths, close the remaining gaps:

- Drop the updateAccessTime param from getAndFilterExpiredEntries —
  the #L fix removed the only caller passing false.
- Collapse LoadingCacheProxy.getAll's private two-arg overload back
  into the public method.
- Remove the outer catch (Throwable t) from both loadAll methods.
  Realistic failures are RuntimeException; Errors propagate uncaught
  and the 10s inFlight.allOf().get(...) close timeout handles stale
  futures. Per the OOME-handling memory, defensive Error cleanup
  isn't load-bearing.
- Drop the JCache-level expired branch in EntryIterator.remove's
  lambda — Caffeine's variable expiry (ExpirableToExpiry) evicts
  before the lambda runs, making that branch dead code.
- Add CacheProxyTest regressions for the remaining branches:
  get_expired_statsDisabled_doesNotRecordGetTime,
  loadAll_cacheLoaderException_unwrapped (and the loading variant),
  iterator_remove_calledTwice_throwsISE,
  iterator_remove_valueChangedConcurrently_doesNotRemove.

4012 of 4020 branches covered (99.8%)

4 of 4 new or added lines in 2 files covered. (100.0%)

8245 of 8245 relevant lines covered (100.0%)

1.0 hits per line