lsm / neokai / 25705211206

Build Type

push

github

Committed by web-flow

Commit Message

fix: enforce task dependencies on late dep addition and auto-unblock on completion (#1865)

* fix: enforce task dependencies on late dep addition and auto-unblock on completion

Two gaps allowed tasks to bypass dependency enforcement:

1. updateTask could add dependsOn to an in_progress task without re-checking.
   Now re-checks areDependenciesMet and blocks the task with
   blockReason='dependency_added' if deps are unmet.

2. Completing a task did not reactivate dependents blocked by
   'dependency_failed'. Now unblockDependentTasks() finds and re-evaluates
   blocked dependents, transitioning them to 'open' when all deps are met.

* fix: address review feedback for task dependency enforcement

- P0: Move unblockDependentTasks into setTaskStatus so all done paths
  trigger the cascade (not just updateTaskAndEmit, which is never called
  with status='done'). Remove dead code from space-runtime.ts.
- P1: Add dependency_added to TaskBlockedBanner REASON_CONFIG.
- Extend updateTask dep re-check to reopen blocked tasks whose deps are
  now satisfied after editing dependsOn.
- Auto-block cascade: call blockDependentTasks after updateTask blocks
  a task, so transitive dependents are also blocked.
- Add tests verifying cascade fires through setTaskStatus('done') path.

* fix: emit events for cascaded dependency state changes

Wire onCascadedTasks callback in all callers so that cascaded
dependency blocks and unblocks propagate task-updated events to
the UI. Also adds the callback to updateTask for late-dep-addition
auto-block cascades, and handles the post-approval-router no-route
bypass that writes done directly to taskRepo.

* fix: use correct task.id in cascade emits, wire callback in RPC handler

emitTaskUpdated in task-agent-tools and end-node-handlers used the
closure-scoped taskId instead of task.id from the parameter, causing
all cascaded dependency events to carry the parent task's ID.
Fixed to use task.id. Also wired onCascadedTasks in the
spaceT... (continued)

Coverage Stats

8347 of 11648 branches covered (71.66%)

Branch coverage included in aggregate %.

113 of 146 new or added lines in 6 files covered. (77.4%)

1 existing line in 1 file now uncovered.

66712 of 79001 relevant lines covered (84.44%)

291.65 hits per line