lsm / neokai / 25700212554

82%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(daemon): remove deprecated NotificationSink dual-publishing path (#1864)

* refactor(daemon): remove deprecated NotificationSink dual-publishing path

Remove the legacy `NotificationSink` interface, its implementations
(`SessionNotificationSink`, `NullNotificationSink`), and all
dual-publishing paths in `SpaceRuntime` and `ChannelRouter`. Space
runtime events now publish exclusively through `InternalEventBus` using
awaited `publish()` instead of fire-and-forget `publishAsync()`.

- Delete `notification-sink.ts` and `session-notification-sink.ts`
- Remove `notificationSink` config from `ChannelRouter` and
  `SpaceRuntime`; remove `setNotificationSink()` / `getNotificationSink()`
- Move `SpaceNotificationEvent` type and `mapNotificationEventToInternalEvent`
  to module-level helpers in `space-runtime.ts`
- Update all test files to use `InternalEventBus` collectors instead of
  `MockNotificationSink`
- Remove obsolete notification-sink and session-notification-sink tests

* fix: correct stale publishAsync/sessionId references in comments

Coverage Stats

8347 of 11648 branches covered (71.66%)

Branch coverage included in aggregate %.

160 of 160 new or added lines in 2 files covered. (100.0%)

5 existing lines in 2 files now uncovered.

66424 of 78781 relevant lines covered (84.31%)

291.07 hits per line