bluesky / hklpy2 / 25694096436

100%

push

github

feat #399 strict refusal of half-defined orientation transitions (#402)

Mutations that would leave the sample half-defined (two or more
reflections still in the dict, but fewer than two named in
`reflections.order` restricted to existing names) now raise
`ReflectionError` before the mutation is committed.  The user must
explicitly designate the new orienting pair (via
`set_orientation_reflections([r1, r2])` or by assigning
`reflections.order = [...]`) before removing the current one, or
remove non-orienting reflections first so the sample falls below the
orientation threshold.

This is option A (strict) from the discussion on #397: the user is
the only authority on which two reflections orient the sample.

Implementation: a new `_check_strict_order_health` helper computes
the prospective post-mutation state and raises early so the dict and
`order` are unchanged when the exception fires.  All nine documented
mutation paths (`Sample.remove_reflection`, `__delitem__`, `pop`,
`popitem`, `clear`, `update`, `__setitem__`, the `order` setter,
and `set_orientation_reflections` / `setor`) gate on the helper.
Multi-step internal operations (`add`, `_fromdict`) suspend the
check via a re-entrant `_suspend_strict_check` context manager so
intermediate states do not trip it.  `calc_UB(r1, r2)` continues to
work because it explicitly re-assigns `order` to a length-2 list
first.

This is a breaking change; the unreleased section bumps from 0.6.3
to 0.7.0 per the project's SemVer policy.

Agent: OpenCode (claudeopus47)

48 of 48 new or added lines in 2 files covered. (100.0%)

3559 of 3559 relevant lines covered (100.0%)

4.99 hits per line