lsm / neokai / 25648129480

82%

push

github

fix(daemon): add pr_url field to review-posted-gate so script can resolve PR URL (#1856)

The review-posted-gate script was failing with "No PR URL available to verify
review" because the gate only declared a `review_url` field. When the Review
node sent `data: { pr_url, review_url }`, the `pr_url` was stripped during
gate write authorization (only declared fields are written), leaving only
`review_url` in gate data.

The script tried `.pr_url // .review_url` from gate data, but `review_url` is
often a review permalink (with #pullrequestreview-...) that `gh pr view` may
not handle correctly. The fallback `gh pr view --json url` also fails when not
on the PR branch.

Fix: add `pr_url` as a declared field on `review-posted-gate` (writable by
Review). Now both `pr_url` and `review_url` are persisted to gate data, and
the script can read the clean PR URL directly.

- Add `pr_url` field to `review-posted-gate` fields array
- Update gate field count test (review-posted-gate now has 2 fields)
- Add test verifying script prefers `pr_url` over `review_url` when both present

8347 of 11648 branches covered (71.66%)

Branch coverage included in aggregate %.

6 of 6 new or added lines in 1 file covered. (100.0%)

65473 of 77880 relevant lines covered (84.07%)

290.31 hits per line