ben-manes / caffeine / #5450

100%

master: 100%

push

github

Record getTime on CacheProxy.get and replace miss/hit short-circuits

CacheProxy.get returned on miss/expired without recording getTime, and
replace(K, V) returned on miss without recording getTime and on hit
without recording getTime alongside putTime. Both methods incremented
hits/misses (which feed getCacheGets), so getAverageGetTime divided by
a denominator that counted the operations while the numerator excluded
them, biasing the average down by the miss ratio. Capture start at
method entry and record getTime on every exit; sample a separate fresh
ticker read for the hasExpired check so the miss-detection ordering is
preserved. replace(K, V) now records getTime on miss and both
getTime+putTime on hit, matching replace(K, V, V) and getAndReplace.

issue found by detail.dev

3995 of 4004 branches covered (99.78%)

15 of 15 new or added lines in 1 file covered. (100.0%)

8207 of 8215 relevant lines covered (99.9%)

1.0 hits per line