ben-manes / caffeine / #5449

100%

master: 100%

Build Type

push

github

Committed by ben-manes

Commit Message

Skip cacheProvider.close on a GC'd ClassLoader

CacheManagerImpl held its ClassLoader via WeakReference. If the loader
was GC'd while the manager remained reachable, close() forwarded null
to cacheProvider.close(uri, ...), which fell back to the default
ClassLoader and could close an unrelated peer manager registered under
the default loader for the same URI. Read the WeakReference once and
skip the forward when the loader is gone — the provider's WeakHashMap
entry has already been expunged, so there's nothing to remove there.

issue found by detail.dev

Coverage Stats

3990 of 3998 branches covered (99.8%)

3 of 3 new or added lines in 1 file covered. (100.0%)

8 existing lines in 2 files now uncovered.

8201 of 8209 relevant lines covered (99.9%)

1.0 hits per line