Freegle / Iznik / 12171

73%

Build Type

push

circleci

Committed by invalid-email-address

Commit Message

perf(microvolunteering): hoist eligibility filter outside per-message loop

V1 (cron/microvolunteering.php → MicroVolunteering::notifyForMessages())
ran a `memberships ⨝ users LEFT JOIN users_notifications … ORDER BY RAND()
LIMIT 10` candidate query for every pending/approved message — ~1900
queries per run, each evaluating the LEFT JOIN against `users_notifications`
for every member of the group. Cron tick took ~3 minutes.

Refactored to:

  1. One run-wide SELECT building {touser => true} for users with any
     microvolunteering Exhort notification in the last 24 h. This is the
     filter the per-message LEFT JOIN was implementing — pulling it out
     means subsequent per-message work can do it in O(1) PHP lookups.
  2. Per (group, collection-type), one SELECT for the active member pool
     (memberships ⨝ users with lastaccess/trust/role predicates only).
     Cached for the run.
  3. Per message, an in-PHP filter (drop poster, anyone in
     notifiedThisRun, anyone in alreadyNotifiedToday) followed by
     array_rand for the random sample. No DB.

Same fairness property as V1 — uniform random sampling per message —
and the MAX_PER_USER existence-check stays in the inner loop. The
schedule is restored to V1's `*/5` (the merge had set it to hourly,
which would have let messages wait up to an hour for review attention).

Live dry-run on prod went from ~3 min (V1 cadence) to ~21 s.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

9133 of 10566 branches covered (86.44%)

Branch coverage included in aggregate %.

41 of 47 new or added lines in 1 file covered. (87.23%)

11935 existing lines in 141 files now uncovered.

102452 of 150790 relevant lines covered (67.94%)

19.58 hits per line