wboayue / rust-ibapi / 25609134981

92%

push

github

chore(news): drop text branches in 4 news decoders (#536)

`decode_news_providers`, `decode_news_bulletin`, `decode_historical_news`,
and `decode_news_article` are now proto-only via
`ResponseMessage::require_proto` — text framing skip-classifies via
`Error::UnexpectedResponse` (rule 20). All originating outgoing-request
gates (`PROTOBUF_NEWS_DATA` = 209) sit at or below the connection floor
of 210 (`PROTOBUF_SCAN_DATA`), so the server always emits these in proto
framing. C# `EDecoder.cs` confirms the dispatch is purely on the 4-byte
msg-id framing — no `if server_version >=` guards.

`decode_tick_news` stays text-framed: it's part of the realtime
market_data family (`PROTOBUF_MARKET_DATA` = 206) and gets dropped in
that family's cleanup PR.

Builders: added `NewsProvidersResponse` (with `NewsProviderEntry` rows),
`NewsBulletinResponse`, `HistoricalNewsResponse`, `HistoricalNewsEndResponse`,
and `NewsArticleResponse` to `testdata/builders/news.rs`. Field-minimal
per rule 24 — only setters tests assert on; `some_str` for String fields
matches positions/orders/contracts builders.

Test fixture migration: 4 sync + 5 async family tests converted from
`response_messages: vec!["text"]` → `with_ordered_responses(vec![proto_response(...)])`.
Tick-news tests (`test_contract_news`, `test_broad_tape_news`,
`test_contract_news_cancellation`) stay on text fixtures pending the
realtime cleanup. Added 4 `*_rejects_text_framing` regression guards.

Modernization (rule 14): extracted inline `mod tests` from `decoders.rs`
and `stream_decoders.rs` to sibling `_tests.rs` files. Dropped unused
`_time_zone` parameter from `decode_historical_news`.

Tracker `plans/legacy-text-protocol-cleanup.md` updated; news row drops
4 text decoders + 4 dual-format calls (1 text decoder remains:
`decode_tick_news`, deferred to realtime cleanup).

150 of 150 new or added lines in 5 files covered. (100.0%)

18390 of 20688 relevant lines covered (88.89%)

28.24 hits per line