wboayue / rust-ibapi / 25586026434

92%

Build Type

push

github

Committed by web-flow

Commit Message

chore(orders): drop text branch in OrderStatus decoder (#531)

`decode_order_status` is now proto-only via the existing `require_proto`
helper. All originating outgoing-request gates (PlaceOrder=203,
RequestOpenOrders/etc.=204) sit at or below the connection floor of 210
(`PROTOBUF_SCAN_DATA`), so the server always emits OrderStatus in proto
framing. C# `EDecoder.cs` confirms the dispatch is purely on the 4-byte
msg-id framing — no `if server_version >=` guards on the proto/text
choice for OrderStatus.

The `decode_order_status_borrowed` alias was a no-op delegate (same
`&mut ResponseMessage` signature); deleted, callers in
`connection/common.rs` use `decode_order_status` directly. Sister
adapter `decode_open_order_borrowed` stays — `decode_open_order` is
still owned-`ResponseMessage` and dual-format.

Tests: two text-fixture unit tests (`_text_unset_double` /
`_text_empty_double`) deleted — the underlying text-decode behavior
they probed is gone. One regression guard added
(`_rejects_text_framing`, mirrors the ExecutionData/CommissionReport
sister tests). ~6 OrderStatus fixtures across
`orders/{sync,async}/tests.rs` swapped from
`text_response(order_status()...encode_pipe())` →
`proto_response(IncomingMessages::OrderStatus,
order_status()...encode_proto())`. `OrderStatusResponse` already had
both `encode_pipe()` and `to_proto()` so the swap was mechanical.

`OrderDecoder` struct + condition decoders + `decode_open_order_text` +
`decode_completed_order_text` stay — still load-bearing for the two
remaining dual-format decoders. They drop together in a follow-up PR
that adds new `OpenOrderResponse` / `CompletedOrderResponse` test
builders (the OpenOrder/CompletedOrder protos are deeply nested with
Contract/Order/OrderState submessages, won't fit in a mechanical sweep).

Tracker `plans/legacy-text-protocol-cleanup.md` updated; orders row
drops 1 text decoder and 1 dual-format call.

Coverage Stats

4 of 4 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

18103 of 20479 relevant lines covered (88.4%)

32.57 hits per line