ruby-grape / grape / 25571296655

97%

master: 97%

Pull #2701

github

Replace .tap usages in lib/ with explicit local variables

`.tap` is idiomatic when you want to perform side effects on a value
and return the value unchanged, but most uses in lib/ were just a
ceremony for "build up a fresh value, then return it" — clearer as
plain locals.

Refactors across 11 files:
- `[].tap { |parts| ... }` → local + explicit return
- `Class.new.tap { |instance| ... }` → local + explicit return
- `Strategies[type].tap { raise unless ... }` → assign-then-raise
- `Rack::Builder.new.tap { ... }` → local + explicit return
- `self.class.new.tap { |s| ... }` → local + explicit return
- `keys.tap { concat + uniq! }` → `(a + b).uniq` with guard clause
- `{}.tap { |details| ... }` → local + explicit return
- `Array.wrap(x).tap { ... }.join(...)` → local, then join
- `Module.new.tap { |mod| ... }` → local + explicit return
- `||= …new.tap { … }` memoization → early-return memoization

Drive-by: replace `handler.instance_of?(Symbol)` with
`handler.is_a?(Symbol)` in `Middleware::Error#run_rescue_handler`
for consistency with the rest of the file (Symbol can't be
subclassed, so the two are behaviorally equivalent here).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

1084 of 1169 branches covered (92.73%)

Branch coverage included in aggregate %.

64 of 68 new or added lines in 11 files covered. (94.12%)

3418 of 3476 relevant lines covered (98.33%)

32141.5 hits per line