agama-project / agama / 25556469923

81%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(web): unsubscribe registration page from software progress (#3456)

## Problem

The registration page is listening to software service progress and
blocking user actions while any software progress is ongoing. This was
intended to prevent users from triggering registration requests while
the service was busy.

In practice, this approach proved counterproductive: users could see
registration-related warnings even before progress had finished, causing
confusion. This happens because the two services are not as
interdependent as the progress subscription assumes, and registration
requests may still be processed even if there are pending software
tasks.

## Solution

Stop listening to software progress on the registration page, based on
two key assumptions:

* The backend will handle requests correctly, as the services are
separate.
* In the future, registration will have its own dedicated service and
progress tracking.

## Additional Changes

Apart from removing the software progress overlay from the product
registration page, this PR improves the overall registration form
experience.

### Registration Form Migration to TanStack Form

Migrated the product registration form to **TanStack Form**, replacing
custom state management. This aligns the registration form with the
latest patterns and conventions established during the network
connection forms reimplementation (documented in
`src/components/form/conventions.md`), ensuring consistency across the
codebase.

The migration brings:

* Proper deferred validation following convention: validate only on
submit
* Better handling of optional and required field states depending on
context (custom server requires URL but not code, default server
requires code but not URL)
* More predictable form state that is easier to reason about
* Elimination of callback hell from nested state updates
* Reusable field components that integrate seamlessly with the
validation system
* Consistent accessibility (proper ... (continued)

Coverage Stats

3996 of 6201 branches covered (64.44%)

Branch coverage included in aggregate %.

141 of 142 new or added lines in 9 files covered. (99.3%)

28 existing lines in 9 files now uncovered.

22443 of 27384 relevant lines covered (81.96%)

95.78 hits per line