zalando-incubator / kube-ingress-aws-controller / 25553781072

72%

Build Type

push

github

Committed by web-flow

Commit Message

Add opt-out support for load-balancer-type: none (#795)

- [x] In `newIngress` (`kubernetes/adapter.go`): return `nil, nil` when
`loadBalancerType == loadBalancerTypeNone`, before the NLB/WAF check and
map lookup
- [x] In `ListIngress` and `ListRoutegroups`: guard append with `ing !=
nil`; log the exclusion at Info level
- [x] Add unit tests: Ingress and RouteGroup with
`zalando.org/aws-load-balancer-type: none` are excluded from
`ListResources`
- [x] Add `TestNewIngressFromRouteGroup` test case: RouteGroup with
`zalando.org/aws-load-balancer-type: none` returns `nil, nil` from
`newIngressFromRouteGroup` (parallel to the `TestNewIngressFromKube`
case)
- [x] Add fixture entry with `zalando.org/aws-load-balancer-type: none`
and class `skipper` to `testdata/fixture01.json` and
`testdata/fixture01_rg.json`; assert count in `TestListIngress` stays at
1
- [x] Add fixture entry with `zalando.org/aws-load-balancer-type: none`
and without class to testdata/fixture01.json and
testdata/fixture01_rg.json; assert count in TestListIngress stays at 1
- [x] Update README
- [x] Bump minor version

Update:
- [x] Move the check for opt out out of the ingress business object
- [x] Add helper function `hasLoadBalancerTypeNone`
- [x] Remove `TestNewIngressFromRouteGroup` and the scenario in
`TestNewIngressFromKube` - these were added because the previous logic
existed within the ingress object, now we check for the load balancer
type `none` early

ref:
https://github.com/zalando-incubator/kube-ingress-aws-controller/issues/794

---------

Signed-off-by: greeshma1196 <greeshma.mathew@gmail.com>

Coverage Stats

27 of 27 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

2948 of 4108 relevant lines covered (71.76%)

12.79 hits per line