pantsbuild / pants / 25547290322

93%

push

github

fix(js): propagate append_only_caches to RunRequest for node_run_script/run_node_build_script (#23300)

# Problem

`pants run` with `node_run_script`/`run_node_build_script` always got a
fresh
ephemeral pnpm store because `RunRequest` was constructed without
`append_only_caches`. The pnpm `PackageManager` declares
`extra_caches={"pnpm_home": "._pnpm_home"}` which the Process carries,
but
`RunRequest` in run/rules.py dropped it. This caused pnpm to
reinstall all packages from scratch on every pants run invocation.
Similarly,
the yarn `PackageManager` declares:
`extra_caches={"yarn_cache": "._yarn_cache"}`.

# Solution

Propagate the `append_only_caches` value to `RunRequest` in
`run/rules.py`.

The `test` `package` and `lint` goals were unaffected — their code paths
correctly forward `append_only_caches` through Process -> named cache
machinery.

Adds a regression tests asserting pnpm_home/yarn_cache appears in
`RunRequest.append_only_caches` when a `node_run_script` or a
`node_build_script` target uses pnpm/yarn as the package manager.

# AI Disclosure

Claude Code was used to diagnose the problem, write the fix with my
input, and write
the regression tests

20 of 20 new or added lines in 1 file covered. (100.0%)

92357 of 99429 relevant lines covered (92.89%)

4.05 hits per line