kobotoolbox / kpi / 25542682493

82%

master: 76%

push

github

refactor(dropzone): update react-dropzone and migrate out of mixin DEV-2081 (#6987)

### 📣 Summary

Upgrade react-dropzone to v15, migrate all Dropzone usages to the
current API, remove legacy droppable mixin usage.

### 💭 Notes

This PR modernizes all Dropzone instances and shared utilities after
upgrade.

Changes here:
- Upgraded `react-dropzone` from `v5` to `v15`
- Migrated all affected Dropzone components to the render-prop API and
modern props
- Replaced className/activeClassName/rejectClassName and disableClick
patterns with getRootProps and dynamic classes
- Removed legacy `mixins.droppable` usage and moved the remaining upload
logic to shared utility functions
- Added a defensive deduplication on `CustomViewStore` until DEV-2082 is
done

### 👀 Preview steps

This is mainly about testing if drag and drop still works after update

1. Open My Library
2. Drag and drop one XLS file, select Upload as template in modal,
confirm Upload
3. Drag and drop multiple XLS files at once
4. Ensure you have at least 30 projects
5. Open My Projects and drag and drop multiple (more than 1) XLS files
6. After imports are created, scroll to load another page
7. 🟢 [on PR] Duplicate append is guarded and list remains stable (no
console errors)
8. 🔴 [on main] Console errors say there are duplicate keys in the list
- This happens because after import finishes on backend the first page
of results (on backend) shifts down because the imported projects are on
the top now, so the few last projects from the first page are now pushed
to second page of results, and after FE loads the (new) second list, the
(old) first page still contains thos shifted projects
9. Open Project → Form, choose "Replace form" icon-button and Upload an
XLSForm; drop file and verify it works
10. Open Project → Settings → Media and drop few files
11. For a project with geopoint question and submissions open Project →
Data → Map; open "Map display settings" and go to "Overlays" tab in
modal; drop-upl... (continued)

9100 of 12254 branches covered (74.26%)

29987 of 36608 relevant lines covered (81.91%)

5.75 hits per line