umputun / ralphex / 25509109438

83%

push

github

feat: add preserve_anthropic_api_key option for API-key auth (#333) (#335)

* feat: add preserve_anthropic_api_key option for API-key auth (#333)

ralphex unconditionally stripped ANTHROPIC_API_KEY from the child claude
process environment. This broke users who authenticate Claude Code via
ANTHROPIC_API_KEY rather than OAuth/keychain — claude started without
credentials, printed "Not logged in", and ralphex bailed out matching
that string against claude_error_patterns.

The strip was deliberate: an OAuth-authenticated user with ANTHROPIC_API_KEY
exported for the SDK would otherwise have claude silently switch to the API
key and bill a different account. Removing the strip unconditionally is not
acceptable, so this change makes it opt-in.

Add `preserve_anthropic_api_key` config option and `--preserve-anthropic-api-key`
CLI flag, default false (existing OAuth-protective behavior). When enabled,
ANTHROPIC_API_KEY is passed through to the claude child. CLAUDECODE continues
to be stripped unconditionally (prevents nested-session errors).

Implementation:
- new claudeChildEnv() helper in pkg/executor/executor.go
- preserveAPIKey field on execClaudeRunner, PreserveAnthropicAPIKey on ClaudeExecutor
- config field with INI parsing, merge sentinel only on Values (Config carries the
  resolved bool, matching the move_plan_on_completion pattern)
- CLI flag + applyCLIOverrides plumbing
- propagation to both task and review ClaudeExecutor instances in runner.go

Tests: TestClaudeChildEnv (5 subtests), TestLoad_PreserveAnthropicAPIKey (3
subtests + invalid-value case), TestPreserveAnthropicAPIKeyFlag (3 subtests).

Fixes #333

* review: address PR #335 feedback

- Add --no-preserve-anthropic-api-key companion flag for per-run safety
  override (go-flags rejects --bool=value, so a paired flag is the
  idiomatic way to express explicit-false override). On conflict the
  no-form wins on safety bias to avoid the billing footgun where a
  config-set true sticks across a... (continued)

78 of 90 new or added lines in 5 files covered. (86.67%)

6894 of 8331 relevant lines covered (82.75%)

225.83 hits per line