lsm / neokai / 25469598267

81%

Build Type

push

github

Committed by web-flow

Commit Message

fix(daemon): explicitly disable thinking when level is 'off' for thinking-capable providers (#1812)

`thinkingLevelToThinkingConfig()` was returning `undefined` when the thinking
level was 'off', which caused the SDK to omit the `thinking` property entirely.
The SDK then fell back to its default behavior of enabling thinking
automatically for supported models. This meant providers like Kimi still
emitted thinking blocks even when the user had set the level to Off.

Now the method returns `{ type: 'disabled' }` for all providers that support
thinking (`thinkingModes !== 'off'`), ensuring the SDK receives an explicit
disable signal. Providers without thinking support continue to get `undefined`
so no `thinking` property is sent to the API.

Updated unit tests to verify the explicit-disable behavior for both
`thinkingModes='on'` (Kimi) and `thinkingModes='granular'` (Anthropic)
providers, and that `thinkingModes='off'` (MiniMax) still omits the property.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

8198 of 11342 branches covered (72.28%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

62897 of 74935 relevant lines covered (83.94%)

288.1 hits per line