nasa / trick / 25441446766
57%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 385
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 56.7% (-0.1%) from 56.83%
25441446766

push

github

web-flow 
Vs security fix (#2106)

* VS Security fixes

* reformatting and update to trick sims

* cleanup

* more cleanup

* docs

* Test fix

* added stuff

* More stuff

* test fix

* trick sims update

* trick sims update2

* Rename to allowlist

* Remove returns for allow, disable, allow_all functions

* Change various function returns to bool

* Added free for getaddrinfo.

* Revise Variable Server documentation for security updates

Updated documentation to clarify that the variable server is disabled by default for security reasons and must be enabled prior to initialization. Enhanced security warnings regarding the potential risks of enabling the variable server.

* Warning update and moving adding localhost to after connections are allowed

* Clarify variable server disabled by default for security

Update documentation to clarify variable server security changes.

* Update default allowed IPs in Variable-Server.md

Clarified the default allowed IPs for the variable server.

* Add session deletion in VariableServerSessionThread_test

Fixed memory management by deleting session in the destructor.

---------

Co-authored-by: Brendan Fattig <brendan.fattig@nasa.gov>
Co-authored-by: Hong Chen <hchen99@users.noreply.github.com>
Co-authored-by: Sean Harmeyer <117398532+sharmeye@users.noreply.github.com>
Co-authored-by: Sean Harmeyer <sean.g.harmeyer@nasa.gov>

51 of 102 new or added lines in 4 files covered. (50.0%)

24 existing lines in 6 files now uncovered.

12902 of 22755 relevant lines covered (56.7%)

301334.0 hits per line

Uncovered Changes

Lines Coverage ∆ File
27
78.29
 -12.07% trick_source/sim_services/VariableServer/VariableServer.cpp
18
34.06
 1.4% trick_source/sim_services/VariableServer/var_server_ext.cpp
5
63.79
 -20.52% trick_source/sim_services/VariableServer/VariableServerSessionThread_loop.cpp
1
88.31
 -0.08% trick_source/sim_services/VariableServer/VariableServerListenThread.cpp

Coverage Regressions

Lines Coverage ∆ File
8
63.79
 -20.52% trick_source/sim_services/VariableServer/VariableServerSessionThread_loop.cpp
5
87.27
 -9.09% trick_source/sim_services/ThreadBase/SysThread.cpp
4
38.33
 -1.15% trick_source/sim_services/Executive/Executive_c_intf.cpp
3
85.0
 -15.0% include/trick/Mock/MockVariableServerSession.hh
2
33.33
 -16.67% include/trick/Mock/MockClientConnection.hh
2
59.04
 -2.41% trick_source/sim_services/Executive/Threads_child.cpp
Jobs
ID Job ID Ran Files Coverage
1 25441446766.1 385
56.7
 GitHub Action Run
Source Files on build 25441446766