nasa / trick / 25441446766

coverage: 56.7% (-0.1%) from 56.83%
25441446766

push

github

web-flow 
Vs security fix (#2106)

* VS Security fixes

* reformatting and update to trick sims

* cleanup

* more cleanup

* docs

* Test fix

* added stuff

* More stuff

* test fix

* trick sims update

* trick sims update2

* Rename to allowlist

* Remove returns for allow, disable, allow_all functions

* Change various function returns to bool

* Added free for getaddrinfo.

* Revise Variable Server documentation for security updates

Updated documentation to clarify that the variable server is disabled by default for security reasons and must be enabled prior to initialization. Enhanced security warnings regarding the potential risks of enabling the variable server.

* Warning update and moving adding localhost to after connections are allowed

* Clarify variable server disabled by default for security

Update documentation to clarify variable server security changes.

* Update default allowed IPs in Variable-Server.md

Clarified the default allowed IPs for the variable server.

* Add session deletion in VariableServerSessionThread_test

Fixed memory management by deleting session in the destructor.

---------

Co-authored-by: Brendan Fattig <brendan.fattig@nasa.gov>
Co-authored-by: Hong Chen <hchen99@users.noreply.github.com>
Co-authored-by: Sean Harmeyer <117398532+sharmeye@users.noreply.github.com>
Co-authored-by: Sean Harmeyer <sean.g.harmeyer@nasa.gov>

51 of 102 new or added lines in 4 files covered. (50.0%)

24 existing lines in 6 files now uncovered.

12902 of 22755 relevant lines covered (56.7%)

301334.0 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

85.0
/include/trick/Mock/MockVariableServerSession.hh
1 
#ifndef MOCK_VARIABLE_SERVER_SESSION_HH
2 
#define MOCK_VARIABLE_SERVER_SESSION_HH
3 









4



#include "trick/VariableServerSession.hh"










5



#include <gmock/gmock.h>










6












7



class MockVariableServerSession : public Trick::VariableServerSession {










8



    public: 











UNCOV

9



        MOCK_METHOD0(handle_message, int());




×







10



        MOCK_METHOD0(write_data, int());




45✔






UNCOV

11



        MOCK_METHOD0(get_exit_cmd, bool());




×







12



        MOCK_METHOD0(get_pause, bool());




48✔





13



        MOCK_CONST_METHOD0(get_enabled, bool());




70✔





14



        MOCK_CONST_METHOD0(get_write_mode, VS_WRITE_MODE());




47✔





15



        MOCK_CONST_METHOD0(get_copy_mode, VS_COPY_MODE());




59✔





16



        MOCK_METHOD1(set_log, int(bool on_off));




4✔





17



        MOCK_METHOD1(set_session_log, int(bool on_off));




4✔





18



        MOCK_METHOD0(copy_sim_data, int());




57✔






UNCOV

19



        MOCK_CONST_METHOD0(get_update_rate, double());




×







20



        MOCK_CONST_METHOD0(get_frame_multiple, int());




10✔





21



        MOCK_CONST_METHOD0(get_frame_offset, int());




10✔





22



        MOCK_CONST_METHOD0(get_freeze_frame_multiple, int());




10✔





23



        MOCK_CONST_METHOD0(get_freeze_frame_offset, int());




10✔





24



        MOCK_CONST_METHOD0(get_next_tics, long long ());




11✔





25



        MOCK_CONST_METHOD0(get_freeze_next_tics, long long());




11✔





26



        MOCK_METHOD0(set_exit_cmd, void());




6✔





27












28



        MOCK_METHOD0(copy_and_write_async, int());




14✔





29












30



        // Accessor for the concrete version










31



        int copy_and_write_async_concrete() { return Trick::VariableServerSession::copy_and_write_async(); }




7✔





32



};










33












34



#endif























    

  • 

    •