MushroomObserver / mushroom-observer / 25439451614

96%

main: 96%

Pull #4223

github

Harden iNat import against duplicates and back-link leak (Fixes #4221)

Add an in-job `already_imported?` check before each MO observation
insert so re-imports of the same iNat observation skip with a log
entry instead of creating a duplicate. Closes the gaps where the
upstream iNat-side `without_field` filter and the controller-side
`clean_inat_ids` filter miss the row (back-link write silently
failed, import-all path bypasses the controller filter, simultaneous
jobs race past both).

Strip MO back-link annotations from the iNat description on import
so re-imports of obs that previously had `Imported by Mushroom
Observer YYYY-MM-DD` or a bare mushroomobserver.org/observations/N
line written into iNat (legacy MO/Pulk's mirror script behavior)
no longer leak those self-referential lines into MO Notes.

Add a regression test confirming the existing rescue at
`finalize_import` does destroy the MO obs when the iNat back-link
write returns an error — so production dupes are from silent
iNat-side failures (200 with no persistence) or simultaneous-job
races, both now caught by the in-job check.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

10 of 10 new or added lines in 2 files covered. (100.0%)

38261 of 39697 relevant lines covered (96.38%)

658.75 hits per line