valkyrjaio / valkyrja-php / 25406785063

100%

push

github

[Http] Rename ResponseFactory(Contract) to RoutingResponseFactory(Contract) (#792)

# Description

Renames `ResponseFactoryContract` → `RoutingResponseFactoryContract` and
`ResponseFactory` → `RoutingResponseFactory` in the
`Valkyrja\Http\Routing\Factory` namespace, mirroring the same
disambiguation applied to the View layer. This eliminates the ambiguity
with
`Valkyrja\Http\Message\Response\Factory\Contract\ResponseFactoryContract`,
which previously required aliased imports at every call site.

As a side effect, `HttpRoutingServiceProvider` and its test no longer
need the aliased `as HttpMessageResponseFactory` import — they now
reference `ResponseFactoryContract` from the HTTP message layer
directly.

---

## Types of Changes

- [ ] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [x] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

---

## Changes

-
**`src/Valkyrja/Http/Routing/Factory/Contract/RoutingResponseFactoryContract.php`**
— renamed from `ResponseFactoryContract`; interface name updated to
match
- **`src/Valkyrja/Http/Routing/Factory/RoutingResponseFactory.php`** —
renamed from `ResponseFactory`; class name, implemented interface, and
aliased import updated to match
-
**`src/Valkyrja/Http/Routing/Provider/HttpRoutingServiceProvider.php`**
— updated imports, publishers key, `publishRouter`, and
`publishResponseFactory` to use the new names; removed now-unnecessary
alias for `HttpMessageResponseFactory`
-
**`tests/Tests/Classes/Application/Data/HttpTestContainerDataClass.php`**
— replaced aliased import with direct `RoutingResponseFactoryContract`
- **`tests/Tests/Unit/Application/Entry/Abstract/AppTest.php`** —
replaced aliased import and assertion to use
`RoutingResponseFac... (continued)

12 of 12 new or added lines in 1 file covered. (100.0%)

12463 of 12465 relevant lines covered (99.98%)

15.87 hits per line