valkyrjaio / valkyrja-php / 25404996180

100%

push

github

[View] Rename response factory (#791)

## Description

Renames `ResponseFactoryContract` → `ViewResponseFactoryContract` and
`ResponseFactory` → `ViewResponseFactory` in the `Valkyrja\View\Factory`
namespace to avoid ambiguity with the HTTP-layer
`ResponseFactoryContract` that lives alongside it in the same codebases.

All consumers — `ViewThrowableCaughtMiddleware`,
`HttpServerServiceProvider`, `EntityRouteMatchedMiddleware`,
`ViewServiceProvider`, and their tests — are updated to reference the
new names.

---

## Types of Changes

- [ ] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [x] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

---

## Changes

-
**`src/Valkyrja/View/Factory/Contract/ViewResponseFactoryContract.php`**
— renamed from `ResponseFactoryContract`; interface name updated to
match
- **`src/Valkyrja/View/Factory/ViewResponseFactory.php`** — renamed from
`ResponseFactory`; class name and implemented interface updated to match
- **`src/Valkyrja/View/Provider/ViewServiceProvider.php`** — updated
imports, publishers key, and `publishResponseFactory` to use the new
names
-
**`src/Valkyrja/Http/Server/Middleware/ThrowableCaught/ViewThrowableCaughtMiddleware.php`**
— updated import and constructor type hint
- **`src/Valkyrja/Http/Server/Provider/HttpServerServiceProvider.php`**
— updated import and container lookup in
`publishViewThrowableCaughtMiddleware`
- **`src/Valkyrja/Orm/Middleware/EntityRouteMatchedMiddleware.php`** —
updated import and constructor type hint
-
**`tests/Tests/Classes/Application/Data/HttpTestContainerDataClass.php`**
— removed aliased import; now uses `ViewResponseFactoryContract`
directly
- **`tests/Tests/Unit/View/Factory/ResponseFactoryTest.php`**... (continued)

10 of 10 new or added lines in 2 files covered. (100.0%)

12463 of 12465 relevant lines covered (99.98%)

15.86 hits per line