pantsbuild / pants / 25401284162

93%

main: 93%

Build Type

push

github

Committed by web-flow

Commit Message

Fix jar-tool repacking for DEFLATED ZIP entries that use data descriptors (Cherry-pick of #23315) (#23318)

Fixes #23316 

## Summary

- fix jar-tool repacking for DEFLATED ZIP entries that use data
descriptors
- add a regression test covering the failing repack path

## Why

The old fast path copied raw compressed bytes by temporarily treating
DEFLATED entries as STORED and patching metadata afterward. That works
for ordinary entries, but it breaks when the source ZIP entry uses a
data descriptor, where size and CRC are finalized after the entry data
instead of being fully available in the local header.
In that case jar-tool could write inconsistent metadata and fail with
ZipException while building deploy jars. This change keeps the fast path
for normal DEFLATED entries, but falls back to safe copy/recompression
for data-descriptor entries.

Co-authored-by: Gregory Borodin <grihabor@gmail.com>

Coverage Stats

38 of 38 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

91804 of 98809 relevant lines covered (92.91%)

3.72 hits per line