tarantool / go-tarantool / 25370127328

76%

master: 75%

Build Type

Pull #589

github

Committed by bigbes

Commit Message

api: redesign errors around errors.Is and errors.As

Rename tarantool.Error to ServerError, promote the seven legacy uint32
client error codes to package-level error sentinels (ErrConnectionClosed,
ErrTimeouted, ...) and expose their numeric form as a typed
ClientErrorCode (CodeConnectionClosed, ...). ClientError gains a Cause
field plus Unwrap() []error so errors.Is matches the sentinel and
errors.As reaches the underlying net error. Retryability is expressed as
a sentinel (ErrRetryable) joined into the chain; IsRetryable wraps
errors.Is. The deprecated Temporary() method is removed.

Internal callers in connection.go and response.go switched to
newClientError / ServerError; I/O failures now wrap the original error
instead of stringifying it. Tests in box, arrow, and the root package
were migrated from typeassertions to errors.As / errors.Is.

Also fixes a pre-existing %x formatting bug on iproto.Error in
ServerError.Error().

Closes #469

Pull Request Pull Request #589: api: redesign errors around errors.Is and errors.As

Coverage Stats

63 of 97 new or added lines in 4 files covered. (64.95%)

8 existing lines in 1 file now uncovered.

3144 of 4155 relevant lines covered (75.67%)

9896.89 hits per line