wboayue / rust-ibapi / 25359668914

92%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(tests): consolidate tests/ into integration/ workspace (#507)

* refactor(tests): consolidate tests/ into integration/ workspace

Moved the only real integration test (conditional_orders) into
integration/{sync,async}/tests/ using ibapi-test helpers (ClientId,
rate_limit, GATEWAY); deleted the rest:

- order_builder_integration.rs — fully duplicated by unit tests under
  src/orders/builder/**/tests.rs.
- test_wsh_async.rs — compile-only stubs; live coverage already in
  integration/{sync,async}/tests/wsh.rs.
- data/wsh-event-data.json — unreferenced.

Also fixes a PriceCondition encoding bug found while running the new
integration tests: encode_condition omitted trigger_method when value
was Default (0), causing TWS to reject with "Invalid value in field
# 6127". C# always emits the field; mirror that. Added unit test.

Updated AGENTS.md and todos/warning-message-routing.md to reflect
the new layout.

* refactor(integration): hoist contract IDs and condition_time_today to ibapi-test

The new conditional_orders tests duplicated three constants and the
YYYYMMDD-with-zone time helper across sync and async. Move them to the
shared ibapi-test crate (no extra dependencies; uses the existing time
crate). conditional_limit_order stays per-file because hoisting it would
require pulling ibapi into ibapi-test.

Coverage Stats

15 of 15 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

17091 of 19471 relevant lines covered (87.78%)

26.04 hits per line