wboayue / rust-ibapi / 25343054113

92%

Build Type

push

github

Committed by web-flow

Commit Message

feat(transport): route warnings with request_id as Notice items (PR 3) (#506)

* feat(transport): route warnings with request_id as Notice items (PR 3)

Warnings (codes 2100..=2169) bound to a real request_id now flow to their
owning subscription as non-terminal SubscriptionItem::Notice items instead
of being diverted to the global error log. Hard errors with a real
request_id continue to terminate the subscription as Err.

- routing.rs: add ErrorDelivery struct (Routing × Severity), classify_error_delivery
- Notice: widen with advanced_order_reject_json, add notice_from_decoded
- sync/async dispatchers: classify, deliver_to_request_id (request first, order fallback), log_unrouted
- Subscription<T>: handle_response pattern-matches on RoutedItem; surfaces Notice
- delete log_error_payload, transport/common.rs log import; DecodedError::is_log_only

Tests: classify_error_delivery boundary codes; sync+async dispatcher tests for
owned warning, unrouted warning, hard error, order-channel fallback;
sync+async Subscription<T> end-to-end Notice surface tests.

* review cleanups: ERROR_TIME guard, doc comments, notice_from_decoded tests

- ResponseMessage::advanced_order_reject_json() gains a server_version >= ERROR_TIME guard, mirroring error_time(); old-format messages always return empty.
- routing::extract_text_error migrated to use the accessor, single source of truth.
- /// doc comments on next_routed/try_next_routed/next_timeout_routed in transport/mod.rs.
- New direct unit tests for notice_from_decoded covering rich-payload preservation and missing-optionals path.
- Plan doc: pruned superseded "Scope — classification" / "Scope — dispatcher rewrite" sections; as-shipped notes are now the source of truth.

* review cleanups: From<&DecodedError> impls, log_unrouted free function

Composability cleanups from the duplication/SRP review:

- log_unrouted body extracted to transport::common::log_unrouted_notice as a free function. Per-transport log_unrouted met... (continued)

Coverage Stats

102 of 118 new or added lines in 10 files covered. (86.44%)

3 existing lines in 2 files now uncovered.

17077 of 19457 relevant lines covered (87.77%)

26.29 hits per line