lsm / neokai / 25345966202

82%

Build Type

push

github

Committed by web-flow

Commit Message

Enable mid-run pickup of gate poll config changes (#1781)

* Enable mid-run pickup of gate poll config changes

When a workflow definition is updated (e.g. poll added/removed/changed on
a gate), actively running workflow runs now pick up the change without
requiring a task restart.

Implementation combines two approaches:
- Event-driven (Option A): Subscribe to spaceWorkflow.updated DaemonHub
  events and immediately refresh poll timers for all active runs using
  that workflow.
- Timer closure reads from shared state: Poll configs are stored on the
  ActivePoll object and read by the timer closure on each tick, so
  script/target/template changes take effect immediately.

Key changes:
- GatePollManager: Add refreshPollsForWorkflow/refreshPollsForRun methods
  that diff gate poll configs and start/stop/update timers as needed.
- GatePollManager: Store poll config, context, and targetNodeId on
  ActivePoll so timer closures read current state instead of stale
  closure captures.
- GatePollManager: Accept PollWorkflowDefProvider to re-read workflow
  definitions from DB during refresh.
- SpaceRuntime: Wire workflowDefProvider into GatePollManager and expose
  onWorkflowDefChanged() for event-driven refresh.
- SpaceRuntimeService: Subscribe to spaceWorkflow.updated events and
  delegate to runtime.onWorkflowDefChanged().

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* Fix two bugs in mid-run poll refresh found by review

1. Update targetNodeId on existing polls when target changes mid-run.
   Previously only pollConfig was updated but targetNodeId stayed stale,
   causing ticks to inject into the wrong node session.

2. Inherit script context from existing peer polls when a new poll is
   added mid-run. Previously new polls got empty TASK_ID/PR fields,
   breaking scripts that depend on those environment variables.

Both fixes include new tests.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* Store scriptContext in runContexts for... (continued)

Coverage Stats

7852 of 10860 branches covered (72.3%)

Branch coverage included in aggregate %.

177 of 203 new or added lines in 3 files covered. (87.19%)

2 existing lines in 2 files now uncovered.

63663 of 89316 relevant lines covered (71.28%)

251.86 hits per line