KarpelesLab / goro / 25325471162

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

vm: native foreach (value form)

Adds OP_FOREACH_INIT, OP_FOREACH_STEP, OP_FOREACH_ADVANCE,
OP_FOREACH_UNWIND. Frame.iters holds the active iterator
stack so nested foreach works.

Coverage:
- foreach (\$src as \$v) {…}
- foreach (\$src as \$k => \$v) {…}
- break / continue inside the loop
- Sources: arrays (snapshotted via Dup() + IncRef/DecRef on
  contained objects), and objects (IteratorAggregate via
  getIterator() + scope-aware NewIteratorInScope, falling
  back to the generic z.NewIterator() — same dispatch the
  AST runnableForeach.Run does).
- Non-iterable src (null/int/etc.) emits the same
  "argument must be of type array|object" warning the AST
  emits, then jumps past the loop.

Out of scope (still falls back to AST):
- by-ref form: foreach (\$src as &\$v)
- value/key target other than a plain local (e.g.
  \$arr[0] as the value receiver, list destructure)
- multi-level break/continue (break 2)

Layout puts the unwind opcode at a single label that's
shared by natural loop end (step jumps there on
\!iter.Valid) and break (which patches there). Continue
patches the advance target. Init's "not iterable" jump
lands past the unwind so we don't over-pop.

phpt suite under GORO_VM=1: zero new regressions (the one
flakey test, bug81104, is a memory-limit timing test that
also flakes on AST).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

120 of 196 new or added lines in 4 files covered. (61.22%)

92 existing lines in 5 files now uncovered.

7652 of 114004 relevant lines covered (6.71%)

802.74 hits per line