KarpelesLab / goro / 25324667258

13%

push

github

vm: native array literals, index read, index/append write

Adds OP_NEW_ARRAY, OP_ARRAY_INIT_APPEND, OP_ARRAY_INIT_KEYED,
OP_ARRAY_GET, OP_ARRAY_SET_LOCAL, OP_ARRAY_APPEND_LOCAL.

Coverage:
- Empty + populated array literals: [], [1,2,3], [k=>v, ...]
- Indexed read: $a[$k] — dispatches at runtime on container
  type (array, object via ArrayAccess, string via ZStringArray,
  null/false → null+warn, scalar → "Cannot use scalar as array")
- Indexed write to local: $local[$k] = $v — handles auto-viv
  from null and (PHP-deprecated) from false, ArrayAccess
  on objects, full string-offset semantics (illegal-offset
  warnings, single-byte truncation, etc.).
- Append to local: $local[] = $v — same auto-viv chain;
  fatal-error on string container ([] not supported).

Spread entries (...$expr), nullsafe access ($obj?->arr[$k]),
non-local LHS containers ($a->p[0] = ..., $arr[0][1] = ...)
fall back to AST via ErrUnsupported.

The runtime helper arraySetLocal in core/vm/ops_array.go
mirrors runArrayAccess.WriteValue's container-type dispatch
so behaviour matches the AST for every supported case.

phpt suite under GORO_VM=1: still zero regressions.
ArrayOps bench: AST and VM now at parity (foreach in the
loop body still falls back; expect a perf win once foreach
lands).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

129 of 265 new or added lines in 5 files covered. (48.68%)

7219 of 113808 relevant lines covered (6.34%)

731.77 hits per line