dangernoodle-io / TaipanMiner / 25284466321

90%

push

github

fix(mining): batch lifetime NVS writes to one open/commit (TA-347) (#313)

mining_stats_save_lifetime was three sequential bb_nv_set_u32 calls,
each opening, setting, committing, and closing its own NVS handle —
3× full flash-bus transactions for one logically atomic snapshot.
On the share-accept hot path under flash contention (TLS handshake,
OTA), the cumulative ~150-300 ms held the SPI bus long enough to
stall the mining_hw task on instruction fetch and trip the task
watchdog on single-core ESP32 WROOM-32.

Inline one nvs_open + 3 sets + one nvs_commit + close on the
ESP-IDF path. Host build still uses bb_nv_set_u32 (no flash, cost
irrelevant). Adds nvs_flash to PRIV_REQUIRES.

The bb_nv API doesn't yet expose batched setters; tracked in
breadboard backlog item B1-165 ("bb_nv: add batched setter for
atomic multi-key commits"), referenced by the inline TODO.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

707 of 852 branches covered (82.98%)

Branch coverage included in aggregate %.

1607 of 1654 relevant lines covered (97.16%)

249583.16 hits per line