lsm / neokai / 25270888469

82%

push

github

Make agent_session_id write-once on node_executions (#1772)

* Make node_execution.agent_session_id write-once to prevent message loss

Once an agent_session_id is assigned to a node_execution during spawn,
it must never be cleared programmatically. Clearing it breaks the live
query join that links sessions to their messages, making all past and
future messages invisible in the task thread UI.

The execution `status` field is the correct mechanism for tracking
lifecycle state and deciding whether to spawn/retry/advance. Downstream
code that relied on agentSessionId being null to detect "needs respawn"
now uses status instead.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* Fix auto-complete and repair loop interaction with write-once agentSessionId

- Guard repair loop with preTickPendingIds to avoid re-elevating
  force-idled executions back to in_progress
- Skip auto-completed executions in non-terminal idle handler filter
  (they retain agentSessionId with write-once)
- Update channel-router test assertion to expect session ID persistence

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* Evict stale session from agentSessionIndex before respawn

When activateTargetSessionsForMessage finds a dead session, it must
remove it from agentSessionIndex so spawnWorkflowNodeAgentForExecution
doesn't short-circuit on the stale entry and reuse the dead session.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* Check liveness in spawn short-circuit to prevent stale session reuse

spawnWorkflowNodeAgentForExecution short-circuits when a session ID
is found in agentSessionIndex, but didn't verify the session is alive.
Now checks isSessionAlive before reusing; evicts dead entries so the
create/reuse path runs instead. Addresses all three Codex review
comments on the non-terminal idle retry, repair loop, and
activateTargetSessionsForMessage paths.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Cl... (continued)

7850 of 10832 branches covered (72.47%)

Branch coverage included in aggregate %.

34 of 34 new or added lines in 2 files covered. (100.0%)

62217 of 87055 relevant lines covered (71.47%)

253.1 hits per line